Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specify paths with more than 1 segments #3

Merged
merged 2 commits into from
Mar 28, 2016

Conversation

velimir
Copy link
Contributor

@velimir velimir commented Mar 21, 2016

Example:

Feature: allow specify full paths
  In order to specify full paths in my features to make requests
  behave-http will need to allow set full paths as well as relative ones

  Scenario Outline: response with appropriate status on incoming requests
    Given I am using server "$TEST_SERVER"
    When I make a GET request to "<path>"
    Then the response status should be <code>

    Examples: good services
    | path                     | code |
    | /good/service            |  200 |
    | /good/service?is_that=ok |  200 |

    Examples: bad services
    | path                     | code |
    | /bad/service             |  404 |
    | /good/service?is_that=no |  503 |

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.63% when pulling f8eb499 on velimir0xff:path-fix into d315383 on mikek:master.

@velimir
Copy link
Contributor Author

velimir commented Mar 22, 2016

partially adresses #1

@mikek mikek merged commit f8eb499 into mikek:master Mar 28, 2016
@mikek
Copy link
Owner

mikek commented Mar 28, 2016

Thanks!

I feel though, if you want to use different base (full) URLs, it might be an indication that you need a separate feature instead.

Also, I am not sure yet what (and if) we can do anything about #1.

@velimir
Copy link
Contributor Author

velimir commented Mar 30, 2016

@mikek I agree with you. It sounds like a different feature, I'll try to find out some new approach for these cases.

@mikek
Copy link
Owner

mikek commented Mar 30, 2016

@velimir0xff note, it's merged nevertheless =)

@velimir
Copy link
Contributor Author

velimir commented Mar 30, 2016

@mikek I know, I'm just interested in this project and going to use it in future, so it's nice to know it's evolving direction :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants