Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination support and also support ?whereIn= in the query string #15

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Pagination support and also support ?whereIn= in the query string #15

wants to merge 26 commits into from

Commits on Apr 27, 2017

  1. Update index.js

    @nabilfreeman
    nabilfreeman authored Apr 27, 2017
    Configuration menu
    Copy the full SHA
    85b06d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Merge pull request #1 from lesalonapp/fix-before-undefined-error 

    Update index.js
    @marineMB
    marineMB authored Jun 26, 2019
    Configuration menu
    Copy the full SHA
    ada9998 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. Add pagination in get for collections

    @marineMB
    marineMB committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    2b44e26 View commit details
    Browse the repository at this point in the history

  2. Add package-lock to gitignore

    @marineMB
    marineMB committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    373b240 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Add query.load in links

    @marineMB
    marineMB committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    4ad1fce View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2019

  1. Remove useless async/await to use only promises

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    cd2b6e7 View commit details
    Browse the repository at this point in the history

  2. Split objects to improve dev reading experience

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    b3d4c23 View commit details
    Browse the repository at this point in the history

  3. Remove comments

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    1094a10 View commit details
    Browse the repository at this point in the history

  4. Add promises to get totalPages and pagination

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    3920335 View commit details
    Browse the repository at this point in the history

  5. Offset is the number of rows that we skip...

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    de6a18c View commit details
    Browse the repository at this point in the history

  6. Improve code by using promise chaining

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    66fa597 View commit details
    Browse the repository at this point in the history

  7. Add comments

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    a35ea91 View commit details
    Browse the repository at this point in the history

  8. Add eslint

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    cc468a6 View commit details
    Browse the repository at this point in the history

  9. Eslint index.js

    @marineMB
    marineMB committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    cde8831 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Merge pull request #2 from lesalonapp/improve-dashboard-perf 

    Add pagination in app.get for Collections
    @MarieFindlay
    MarieFindlay authored Jul 9, 2019
    Configuration menu
    Copy the full SHA
    8f3a34f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Update package.json

    @nabilfreeman
    nabilfreeman authored Jul 11, 2019
    Configuration menu
    Copy the full SHA
    5ac22ea View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. when counting the number of pages, clone the model so we don't accide… 

    …ntally discard our where filtering
    @nabilfreeman
    nabilfreeman committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    05f5605 View commit details
    Browse the repository at this point in the history

  2. chain orderBy, limit, offset onto the original model

    @nabilfreeman
    nabilfreeman committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    981cef2 View commit details
    Browse the repository at this point in the history

  3. By hardcoding the structure of the query we excluded where. Also, thi… 

    …s is bad practice because load and where are both optional so we should only put them in the URL if they are actually supplied.
    @nabilfreeman
    nabilfreeman committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    c8c8f7f View commit details
    Browse the repository at this point in the history

  4. initialize the model outside of the where query check, I think this i… 

    …s cleaner because it's clear that where is one of many optional parameters.
    @nabilfreeman
    nabilfreeman committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    389090f View commit details
    Browse the repository at this point in the history

  5. Add qs to package.json and bump version

    @nabilfreeman
    nabilfreeman committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    ebe523a View commit details
    Browse the repository at this point in the history

  6. Merge pull request #3 from lesalonapp/pagination-where-crash 

    Pagination breaks ?where query
    @nabilfreeman
    nabilfreeman authored Jul 17, 2019
    Configuration menu
    Copy the full SHA
    bb168b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Add conditional looking for a whereIn in the query

    @runticle
    runticle committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    ebe2092 View commit details
    Browse the repository at this point in the history

  2. really annoying to test this

    @runticle
    runticle committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    b67431b View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Improve json comment example

    @nabilfreeman
    nabilfreeman authored Oct 22, 2021
    Configuration menu
    Copy the full SHA
    180c144 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4 from lesalonapp/Allow-whereIn-in-the-query 

    Allow where in in the query
    @nabilfreeman
    nabilfreeman authored Oct 22, 2021
    Configuration menu
    Copy the full SHA
    98aa706 View commit details
    Browse the repository at this point in the history