-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable adapterOptions to be used in buildURL method #214
base: master
Are you sure you want to change the base?
Conversation
I wouldn't hold your breath on getting this merged, it seems the maintainer is a bit busy. Lots of other good PR's not getting merged or even responded to. It looks like this PR allows creation of different URLs for the same memberAction/collectionAction, by changing the adapterOptions when making the call, and then having something in buildURL deal with that. Looks good to me. You might want to add some tests though.
Just for those that come here wanting to simply change the built url per api endpoint (rather than per call of that endpoint), I think you can potentially already do this, by setting
This way each memberAction/collectionAction endpoint you create can have its own URL |
93f3fad
to
9ed5abb
Compare
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
9ed5abb
to
3e80d0e
Compare
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
3e80d0e
to
f4be757
Compare
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Allows api actions to take an optional `options` object. If you pass an object on the adapterOptions property of the options argument it will be passed to your adapter via the snapshot. Similar to ember data Store and Modal functions, for example https://api.emberjs.com/ember-data/3.25/classes/Store/methods/findAll?anchor=findAll https://api.emberjs.com/ember-data/3.25/classes/Model/methods/save?anchor=save This is similar to mike-north#214 with tests. Closes mike-north#214
Allows api actions to take an optional `options` object. If you pass an object on the adapterOptions property of the options argument it will be passed to your adapter via the snapshot. Similar to ember data Store and Modal functions, for example https://api.emberjs.com/ember-data/3.25/classes/Store/methods/findAll?anchor=findAll https://api.emberjs.com/ember-data/3.25/classes/Model/methods/save?anchor=save This is similar to mike-north#214 with tests. Closes mike-north#214
Allows api actions to take an optional `options` object. If you pass an object on the adapterOptions property of the options argument it will be passed to your adapter via the snapshot. Similar to ember data Store and Modal functions, for example https://api.emberjs.com/ember-data/3.25/classes/Store/methods/findAll?anchor=findAll https://api.emberjs.com/ember-data/3.25/classes/Model/methods/save?anchor=save This is similar to mike-north#214 with tests. Closes mike-north#214
98e0a1f
to
f4be757
Compare
This change would enable me to use adapterOptions to differentiate the buildURL per custom api endpoint. Probably this is something others would like as well.