Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Ising model #33

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Add support for the Ising model #33

wants to merge 18 commits into from

Commits on Apr 11, 2023

  1. Feat: add implementation for the Ising model 

    The implementation is based on the method by van Borkulo et al. (2014).
    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8cd5ad2 View commit details
    Browse the repository at this point in the history

  2. Feat: add Ising model to ModelFactory

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ea5e03a View commit details
    Browse the repository at this point in the history

  3. Refactor: increase minimum sample size to 100

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7e70a7e View commit details
    Browse the repository at this point in the history

  4. Refactor: drop superfluous args from Ising estimate method

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c152e2e View commit details
    Browse the repository at this point in the history

  5. Refactor: drop redundant likelihood in IsingModel

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6a24604 View commit details
    Browse the repository at this point in the history

  6. Fix: create correct storage for thresholds in IsingModel

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    705d68d View commit details
    Browse the repository at this point in the history

  7. Refactor: simplify return for estimate method in IsingModel

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a2ae8eb View commit details
    Browse the repository at this point in the history

  8. Refactor: simplify return for create method in IsingModel

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d083789 View commit details
    Browse the repository at this point in the history

  9. Perf: swap sampler for generate in IsingModel 

    Currently using the internal `C++` sampler `IsingSampler:::IsingSamplerCpp`.
    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a53507d View commit details
    Browse the repository at this point in the history

  10. Fix: update evaluate in IsingModel to match changes

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3168406 View commit details
    Browse the repository at this point in the history

  11. Fix: update usage of un-exported Ising sampler 

    The update is due to `:::` not being accepted by CRAN.
See this answer: https://stackoverflow.com/a/46098814/5252007.
    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    35f82e6 View commit details
    Browse the repository at this point in the history

  12. Refactor: update argument name in IsingModel

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    68ad37d View commit details
    Browse the repository at this point in the history

  13. Test: add tests for IsingModel class methods

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5675a9c View commit details
    Browse the repository at this point in the history

  14. Build: update package imports for IsingModel

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c540d99 View commit details
    Browse the repository at this point in the history

  15. Build: add IsingModel.R to collate in DESCRIPTION

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2512e6a View commit details
    Browse the repository at this point in the history

  16. Docs: update package docs with Ising model information

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a73d454 View commit details
    Browse the repository at this point in the history

  17. Docs: add changes to NEWS

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1507586 View commit details
    Browse the repository at this point in the history

  18. Style: add comment for IsingModel class

    @mihaiconstantin
    mihaiconstantin committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    63bc202 View commit details
    Browse the repository at this point in the history