Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing file name for tailwind.config.mjs #264

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

victorbadaro
Copy link
Contributor

@victorbadaro victorbadaro commented Dec 7, 2024

What does this PR fix?

Fix: #263
It adds the tailwind.config.mjs file name to the symbol-icon-theme.json file names list

Before:
image

Now:
image

@sebastiandotdev
Copy link

@victorbadaro,

Adding the tailwind.config.mjs is great... But you formatted the symbol-icon-theme.json file maybe you should fix that.

@victorbadaro
Copy link
Contributor Author

@victorbadaro,

Adding the tailwind.config.mjs is great... But you formatted the symbol-icon-theme.json file maybe you should fix that.

Thank you, mate! I think the file wasn't formatted before, actually.
I really formatted it wrong the first time (ignoring the biome settings), but I've already fixed it.
Also, the file, as it is now, reflects the result of running npm run format.

@miguelsolorio
Copy link
Owner

miguelsolorio commented Dec 9, 2024

@victorbadaro thanks for the PR, I think your formatter may have changed the format. Running npm run format on main does not produce the same as your PR. Do you mind undoing those? Thanks.

@victorbadaro
Copy link
Contributor Author

@victorbadaro thanks for the PR, I think your formatter may have changed the format. Running npm run format on main does not produce the same as your PR. Do you mind undoing those? Thanks.

Done!

It might have been some bug in my vscode or something like that (maybe a default formatter).
Even after running npm run format, the file stayed the same.
Now, it's fixed!

Sorry about that, guys! 😅
@sebastiandotdev @miguelsolorio

@miguelsolorio miguelsolorio self-assigned this Dec 14, 2024
@miguelsolorio miguelsolorio added this to the 0.0.22 milestone Dec 14, 2024
@miguelsolorio miguelsolorio merged commit 59b9420 into miguelsolorio:main Dec 14, 2024
1 check passed
@miguelsolorio miguelsolorio added the icon request Request for a new icon label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon request Request for a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing file name for tailwind files
3 participants