Skip to content

Commit

Permalink
roll to Chrome 117.0.5938.149 (r1181205)
Browse files Browse the repository at this point in the history
latest stable
also fix cli browser download
  • Loading branch information
mifi committed Oct 7, 2023
1 parent 97b2ac2 commit 899f3ba
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Tests
on: [push, pull_request]

env:
CHROME_BUILD_NUMBER: 1056772
CHROME_BUILD_NUMBER: 117.0.5938.149

jobs:
test:
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:

- run: yarn

- run: npx @puppeteer/browsers install chrome@${{ env.CHROME_BUILD_NUMBER }} browser/chrome
- run: npx @puppeteer/browsers install chrome@${{ env.CHROME_BUILD_NUMBER }} --path browser

- run: yarn workspace reactive-video build
- run: npm test
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ export default () => {

### Download Chrome

You need to have installed Chrome/Chromium. Currently Chrome buildId 1056772 is supported/tested. You can download the correct Chrome build to the directory `browser` (in the current directory):
You need to have installed Chrome/Chromium. Currently Chrome buildId 117.0.5938.149 is supported/tested. You can download the correct Chrome build to the directory `browser` (in the current directory):
```bash
npx @puppeteer/browsers install chromium@1056772 browser
npx @puppeteer/browsers install chromium@117.0.5938.149 --path browser
```

### Shell
Expand Down Expand Up @@ -116,7 +116,7 @@ Create `index.js`:
```js
const Editor = require('@reactive-video/builder');

const browserExePath = require('@puppeteer/browsers').computeExecutablePath({ cacheDir: './browser', browser: 'chrome', buildId: '1056772' }); // remember to download it first
const browserExePath = require('@puppeteer/browsers').computeExecutablePath({ cacheDir: './browser', browser: 'chrome', buildId: '117.0.5938.149' }); // remember to download it first

(async () => {
const editor = Editor({
Expand Down
4 changes: 3 additions & 1 deletion packages/builder/tests/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ async function edit(editor, opts) {
});
}

const browserExePath = computeExecutablePath({ cacheDir: './browser', browser: 'chrome', buildId: '1056772' });
const chromeBuildId = '117.0.5938.149';

const browserExePath = computeExecutablePath({ cacheDir: './browser', browser: 'chrome', buildId: chromeBuildId });

// override logger: null to get log output
const getEditor = (opts) => Editor({ ffmpegPath: 'ffmpeg', ffprobePath: 'ffprobe', browserExePath, logger: null, ...opts });
Expand Down

0 comments on commit 899f3ba

Please sign in to comment.