Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ffmpeg child-process & allow URL paths #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tan-tan-kanarek
Copy link

@tan-tan-kanarek tan-tan-kanarek commented Aug 5, 2020

The purpose of these changes is to expose ffmpeg process to higher level in order to log the ffmpeg command using application logging framework and in order to have better control on the child process for piping std in, out and err or to kill the process when needed.

Also support remote input files over http

@tan-tan-kanarek
Copy link
Author

merged 0.5.0

@maksym-plotnikov
Copy link

@tan-tan-kanarek could be also useful if You add onProgress callback function to pass overall progress output to higher level.

@tan-tan-kanarek
Copy link
Author

It's a good idea, but not something I need at the moment because I use the canvas renderer where I'm already well aware to the progress.
Are there any comments or improvements I can do to promote this PR to be merged?

@mifi mifi changed the title Expose ffmpeg child-process Expose ffmpeg child-process & allow URL paths Sep 23, 2020
@mifi
Copy link
Owner

mifi commented Sep 23, 2020

This PR is two features in one (allow http/https + onStart / onProcessStart)

@mifi mifi added the enhancement New feature or request label Sep 23, 2020
mifi added a commit that referenced this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants