Support for logo/watermark #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. I'm not sure if ffmpeg filter complex is the way I want to solve this, but can leave it open to see. I think also this kind of full-video watermark can easily be added in post-process after editly's output for those who want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for a logo or watermark to be added (i.e. an image overlay that persists for the whole video, independent of individual clips). See #102 for existing issue. This works by inserting an additional input file to the
ffmpegparameters and using afilter_complexto scale the logo and overlay it over the main video input stream.Limitations:
allowRemoteRequestsistrue, though presumably it would not be difficult to cache remote images locally to use in the same way.gif). I don't think the ffmpeg gif muxer supports multiple video inputs