Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print SSHFP fingerprint as lowercase hex #1478

Closed
wants to merge 1 commit into from
Closed

Print SSHFP fingerprint as lowercase hex #1478

wants to merge 1 commit into from

Conversation

tomfitzhenry
Copy link
Contributor

@tomfitzhenry tomfitzhenry commented Aug 22, 2023 •
edited
Loading

https://datatracker.ietf.org/doc/html/rfc4255#section-3.2 uses lowercase, doesn't mention case sensitivity, and some SSHFP validation implementations require lowercase.

Argument against this PR:

  • it could break some users (e.g. test cases relying on string-representation of RRs)
  • https://en.wikipedia.org/wiki/Robustness_principle suggests the burden is on validation implementations to be liberal (i.e. accept upper or lower case): hex is commonly understand to be case insensitive anyway

@tomfitzhenry tomfitzhenry marked this pull request as ready for review August 22, 2023 16:18
@tomfitzhenry
Copy link
Contributor Author

tomfitzhenry commented Aug 30, 2023 •
edited
Loading

On reflection, I'm not convinced by this PR. Instead, parsers should be case insensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miekg miekg Awaiting requested review from miekg miekg is a code owner

@tmthrgd tmthrgd Awaiting requested review from tmthrgd tmthrgd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomfitzhenry