Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigmf: Add support for datasets #236

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

jdemel
Copy link
Contributor

@jdemel jdemel commented Jun 28, 2024

Sometimes, we want to load a data file found under the core:dataset key. In these cases, we need to read the dataset key and overwrite the respective variable.
Further, we'd need to check if the corresponding sigmf-data file exists, because it is supposed to take precedence over the dataset file. The dataset file is all called a Non-Conforming-Datafile (NCD).

Sometimes, we want to load a data file found under the `core:dataset`
key. In these cases, we need to read the dataset key and overwrite the
respective variable.
Further, we'd need to check if the corresponding `sigmf-data` file
exists, because it is supposed to take precedence over the dataset file.
The dataset file is all called a Non-Conforming-Datafile (NCD).

Signed-off-by: Johannes Demel <[email protected]>
Copy link

@jacobagilbert jacobagilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement!

@miek miek merged commit 6a1ee5a into miek:main Jul 21, 2024
3 checks passed
@miek
Copy link
Owner

miek commented Jul 21, 2024

Thanks!

@jdemel jdemel deleted the add-sigmf-dataset-support branch July 29, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants