Fix middleman v4 compatibility issues #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the separate file was defining a Middleman::Smusher module, while in fact, Middleman::Smusher is a subclass of Middleman::Extension. This caused conflicts, when loading the extension. Removing the separate file and adding the version number directly to the gemspec was the simplest solution. Changing the declaration within version.rb to the proper class definition would defeat the idea of a simple, easy-to-load version file, which can be used from the gemspec without further prerequisites.
Since the non-ssl version is discouraged and insecure.
We only need to load smusher, when the extension is activated.
* loading middleman-core as recommended by the default plugin skeleton * fix null vs. nil default value declaration * `build_dir` is no longer available, using `app.config[:build_dir]` instead * `say_status`: builder does not return thor instance directly anymore * Current Smusher API provides `convert_gifs` option, not `with_gifs`. Also updating middleman version requirement, to make sure that the code is not used with older versions of middleman.
|
Is there a reason this hasn't been merged? Running into some smusher compatibility issues on our recent bundle update and I think this may be useful. |
|
I am also running into similar issues. Looking forward to this PR being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was facing a number of incompatibilities, when trying to use middleman-smusher with a current middleman v4.2.1. This pull request tries to address all of them. Please take a look at the individual commits for a detailed description of the changes.