Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes Junit and mockito dependecies #2143

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Removes Junit and mockito dependecies #2143

merged 5 commits into from
Sep 3, 2024

Conversation

timayabi2020
Copy link
Contributor

@timayabi2020 timayabi2020 commented Sep 3, 2024 •
edited
Loading

Fixes #2133
Removes Junit and Mockito dependencies because there are no unit tests for this SDK. This will also reduce the number of dependabot PRs

@timayabi2020 timayabi2020 requested a review from a team as a code owner September 3, 2024 13:07
@timayabi2020 timayabi2020 linked an issue Sep 3, 2024 that may be closed by this pull request
replace mockito inline by mockito core #2133
Closed
baywet
baywet requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also bump the java version of the workflows to 21 please?

Ndiritu
Ndiritu reviewed Sep 3, 2024
View reviewed changes
gradle/dependencies.gradle Outdated Show resolved Hide resolved
@timayabi2020
Copy link
Contributor Author

timayabi2020 commented Sep 3, 2024 •
edited
Loading

Can you also bump the java version of the workflows to 21 please?

The versions in the workflows were already bumped to 21. The one that we will need to bump is in the java core. I also think we actually don't need mockito here because there are no unit tests here. Same for Junit dependencies too.

@baywet
Copy link
Member

baywet commented Sep 3, 2024

since we don't have any unit test on the generated code we I think we could remove the junit and mockito dependencies, it'd reduce the number of dependabot PRs we get

@timayabi2020 timayabi2020 changed the title Replaces mockito inline with mockito-core to 5.12.0 Removes Junit dependencies and test step from build.gradle Sep 3, 2024
@timayabi2020 timayabi2020 changed the title Removes Junit dependencies and test step from build.gradle Removes Junit and mockito dependecies Sep 3, 2024
@baywet
Copy link
Member

baywet commented Sep 3, 2024

@timayabi2020 I can see that you've requested a review but the code hasn't changed. Did you forget to push by any chance?

@timayabi2020
Copy link
Contributor Author

@timayabi2020 I can see that you've requested a review but the code hasn't changed. Did you forget to push by any chance?

I think my network timed out during the process

@timayabi2020 timayabi2020 merged commit c84c2c6 into main Sep 3, 2024
13 checks passed
@timayabi2020 timayabi2020 deleted the 2133-replace-mockito-inline-by-mockito-core branch September 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndiritu Ndiritu Ndiritu left review comments

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace mockito inline by mockito core
3 participants
@timayabi2020 @baywet @Ndiritu