-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes overriding default interceptors and customizing their configuration #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndiritu
force-pushed
the
fix/handler-overrides
branch
from
November 12, 2024 14:50
aca1a57
to
0e0f2cd
Compare
Ndiritu
changed the title
Fixes overriding default interceptor behaviour
Fixes overriding default interceptors and their configuration
Nov 12, 2024
Ndiritu
changed the title
Fixes overriding default interceptors and their configuration
Fixes overriding default interceptors and customizing their configuration
Nov 12, 2024
Coverage checks still need to be fixed. Bumped the priority here |
baywet
reviewed
Nov 15, 2024
Ndiritu
force-pushed
the
fix/handler-overrides
branch
2 times, most recently
from
November 19, 2024 09:37
82c9fe7
to
a0eea05
Compare
Ndiritu
force-pushed
the
fix/handler-overrides
branch
from
November 19, 2024 10:08
a0eea05
to
0a815b3
Compare
Quality Gate failedFailed conditions |
baywet
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for cleaning things up!
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the work started in #1758.
Thanks @raghusammeta @raghucha
RequestOption
. Adds multiple method overloads that acceptRequestOption[]
TokenCredential
to enable auth in the middleware. Reduces steps needed previously to init an auth provider with an AccessTokenProvider etccloses #1757