Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove manual version bump, rely on release please for go #1236

Merged
merged 2 commits into from
May 27, 2024

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented May 27, 2024

Summary

Removes the manual version bump script for go and rely on release please configured in the repo

Links to issues or work items this PR addresses

Follow up to PR's microsoftgraph/msgraph-sdk-go#713 and microsoftgraph/msgraph-beta-sdk-go#418

Microsoft Reviewers: Open in CodeFlow

@rkodev rkodev requested a review from a team as a code owner May 27, 2024 09:41
@andrueastman
Copy link
Member

Out of curiosity, do you also need a change like #1212 or is that already handled?

@rkodev
Copy link
Contributor Author

rkodev commented May 27, 2024

Out of curiosity, do you also need a change like #1212 or is that already handled?

Good catch, That's required.

@rkodev rkodev merged commit e9582aa into dev May 27, 2024
5 checks passed
@rkodev rkodev deleted the feat/go/migrate-to-release-please branch May 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants