This repository has been archived by the owner on Feb 20, 2021. It is now read-only.
Fixes issue with master killing client connections while redis is write #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load. reply_bytes was being wrapped to huge values, e.g.omem=18446744073709551601 causing redis to close the connection as it thought the client buffer limit had been exceeded. See https://github.com/antirez/redis/blob/3.0/src/networking.c#L827
ghost
added
the
|
is this related to #546 ? |
|
facing similar issue here. our master is constantly dropping slave connections which in turn is causing our slaves to reconnect to master and re-syncing its replication.
|
|
Hi, I am also constantly seeing this issue in our setup whenever client starts writing a lot of data in a short time. the omem value reported is suspect (very large number) can we have a release with a fix to this issue please? using version 3.0.503 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with master killing client connections while redis is under high write loads
reply_bytes was being wrapped to huge values,
e.g.omem=18446744073709551601 causing redis to close the connection as it
thought the client buffer limit had been exceeded.
See https://github.com/antirez/redis/blob/3.0/src/networking.c#L827