Use stack-based formatter for debug-printing. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable print!/println! macros to be used in <=DIRQL environments.
|
@microsoft-github-policy-service agree |
Also remove unnecessary mutable reference.
|
It's been a few weeks since this PR is opened. Someone please review this PR. |
|
Ping: It's been a month since I opened this PR. Someone please review this PR. |
Hey @Zero-Tang. Thanks for the PR. I've already gone thru it as a surface level and it LGTM, but we're having some discussions about it internally, as well as going thru some testing with it. I will get this merged in when that has concluded. |
|
Sounds great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable
print!andprintln!macros to be used in<=DIRQLlevels.If
alloccrate is used,ExAllocatePool2will fail in>DISPATCH_IRQLlevels.