Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move infverif task's condition script logic to cargo_make.rs #216

Merged
merged 7 commits into from
Sep 23, 2024
Merged

refactor: move infverif task's condition script logic to cargo_make.rs #216

merged 7 commits into from
Sep 23, 2024

Conversation

svasista-ms
Copy link
Contributor

@svasista-ms svasista-ms commented Sep 9, 2024 •
edited
Loading

Closes #172

  • Moved the InfVerif task's condition script logic from rust-driver-sample-makefile.toml to a function in cargo-make.rs.
  • Ensured the utils module remains private.

@svasista-ms svasista-ms marked this pull request as draft September 9, 2024 14:35
@svasista-ms svasista-ms marked this pull request as ready for review September 9, 2024 15:02
@svasista-ms svasista-ms closed this Sep 9, 2024
@svasista-ms svasista-ms reopened this Sep 9, 2024
@wmmc88 wmmc88 requested review from wmmc88 and NateD-MSFT September 10, 2024 15:48
wmmc88
wmmc88 reviewed Sep 10, 2024
View reviewed changes
crates/wdk-build/src/lib.rs Outdated Show resolved Hide resolved
@wmmc88 wmmc88 self-assigned this Sep 11, 2024
wmmc88
wmmc88 requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@wmmc88 wmmc88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Good to merge it after those are addressed

crates/wdk-build/src/cargo_make.rs Outdated Show resolved Hide resolved
crates/wdk-build/src/cargo_make.rs Outdated Show resolved Hide resolved
crates/wdk-build/rust-driver-sample-makefile.toml Outdated Show resolved Hide resolved
crates/wdk-build/src/cargo_make.rs Outdated Show resolved Hide resolved
crates/wdk-build/src/cargo_make.rs Outdated Show resolved Hide resolved
@wmmc88 wmmc88 added this pull request to the merge queue Sep 23, 2024
Merged via the queue into microsoft:main with commit 0107914 Sep 23, 2024
62 checks passed
@wmmc88 wmmc88 mentioned this pull request Sep 27, 2024
Merged
@svasista-ms svasista-ms deleted the move-infverif-latest branch October 1, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzamust hamzamust hamzamust approved these changes

@wmmc88 wmmc88 wmmc88 approved these changes

@ayodejiige ayodejiige ayodejiige approved these changes

@NateD-MSFT NateD-MSFT Awaiting requested review from NateD-MSFT

Assignees

@wmmc88 wmmc88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move infverif samples condition_script into cargo_make.rs
5 participants
@svasista-ms @ayodejiige @wmmc88 @NateD-MSFT @hamzamust