-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more precise NTSTATUS const fns #183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NateD-MSFT
changed the title
Add more precise NTSTATUS macros.
Add more precise NTSTATUS const fns.
Jul 9, 2024
ChrisDenton
reviewed
Jul 11, 2024
For reference, here's how they're defined in C: #define NT_SUCCESS(Status) (((NTSTATUS)(Status)) >= 0)
#ifdef _PREFAST_
#define NT_INFORMATION(Status) (((NTSTATUS)(Status)) >= (long)0x40000000)
#else
#define NT_INFORMATION(Status) ((((ULONG)(Status)) >> 30) == 1)
#endif
#ifdef _PREFAST_
#define NT_WARNING(Status) (((NTSTATUS)(Status) < (long)0xc0000000))
#else
#define NT_WARNING(Status) ((((ULONG)(Status)) >> 30) == 2)
#endif
#ifdef _PREFAST_
#define NT_ERROR(Status) (((NTSTATUS)(Status)) >= (unsigned long)0xc0000000)
#else
#define NT_ERROR(Status) ((((ULONG)(Status)) >> 30) == 3)
#endif |
wmmc88
requested changes
Jul 12, 2024
hamzamust
previously approved these changes
Jul 17, 2024
wmmc88
reviewed
Sep 4, 2024
wmmc88
approved these changes
Sep 5, 2024
wmmc88
changed the title
Add more precise NTSTATUS const fns.
feat: add more precise NTSTATUS const fns
Sep 5, 2024
hamzamust
approved these changes
Sep 5, 2024
@wmmc88 it looks like one of the docs jobs hanged. Can you restart it or bypass it? |
Ah. Hanged on winget installation. Winget installation is primarily used to get the WDK. Do you think someone could port the pipelines to use the new nuget pkgs? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current NT_SUCCESS macro checks for NTSTATUS >= 0. While this is semantically equivalent to the official behavior I think it is appropriate to match MSDN documentation exactly.
This PR also adds the other NT_ macros for information, warning, and error values.
Reference: https://learn.microsoft.com/en-us/windows-hardware/drivers/kernel/using-ntstatus-values