fix triggering lints

Cargo.toml

@@ -32,7 +32,7 @@ serde_json = "1.0"
 #
 # [lints]
 # workspace = true
-# 
+
 [workspace.lints.rust]
 missing_docs = "warn"
 unsafe_op_in_unsafe_fn = "forbid"

crates/sample-kmdf-driver/build.rs

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation
 // License: MIT OR Apache-2.0
 
+//! Build script for the `sample-kmdf-driver` crate.
+
 fn main() -> Result<(), wdk_build::ConfigError> {
     wdk_build::Config::from_env_auto()?.configure_binary_build()
 }

crates/sample-kmdf-driver/src/lib.rs

@@ -1,6 +1,11 @@
 // Copyright (c) Microsoft Corporation
 // License: MIT OR Apache-2.0
 
+//! # Sample KMDF Driver
+//!
+//! This is a sample KMDF driver that demonstrates how to use the crates in
+//! windows-driver-rs to create a skeleton of a kmdf driver.
+
 #![no_std]
 
 extern crate alloc;

crates/wdk-build/Cargo.toml

@@ -32,5 +32,37 @@ windows = { version = "0.52.0", features = ["Win32_UI_Shell"] }
 # // versions is not a concern
 #![allow(clippy::multiple_crate_versions)]
 
-[lints]
-workspace = true
+# Cannot inherit workspace lints since overriding them is not supported yet: https://github.com/rust-lang/cargo/issues/13157
+# [lints]
+# workspace = true
+# 
+# Differences from the workspace lints have comments explaining why they are different
+
+[lints.rust]
+missing_docs = "warn"
+unsafe_op_in_unsafe_fn = "forbid"
+
+[lints.clippy]
+# Lint Groups
+all = "deny"
+pedantic = "warn"
+nursery = "warn"
+cargo = "warn"
+# Individual Lints
+# multiple_unsafe_ops_per_block = "forbid"
+multiple_unsafe_ops_per_block = "deny" # This is lowered to deny since clap generates allow(clippy::restriction) in its Parser and Args derive macros
+# undocumented_unsafe_blocks = "forbid"
+undocumented_unsafe_blocks = "deny" # This is lowered to deny since clap generates allow(clippy::restriction) in its Parser and Args derive macros
+# unnecessary_safety_doc = "forbid"
+unnecessary_safety_doc = "deny" # This is lowered to deny since clap generates allow(clippy::restriction) in its Parser and Args derive macros
+
+[lints.rustdoc]
+bare_urls = "warn"
+broken_intra_doc_links = "warn"
+invalid_codeblock_attributes = "warn"
+invalid_html_tags = "warn"
+invalid_rust_codeblocks = "warn"
+missing_crate_level_docs = "warn"
+private_intra_doc_links = "warn"
+redundant_explicit_links = "warn"
+unescaped_backticks = "warn"

crates/wdk-build/build.rs

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation
 // License: MIT OR Apache-2.0
 
+//! Build script for the `wdk-build` crate.
+
 #[rustversion::nightly]
 fn main() {
     println!("cargo:rustc-cfg=nightly_toolchain");

crates/wdk-macros/Cargo.toml

@@ -49,5 +49,35 @@ development = [
 default = []
 nightly = []
 
-[lints]
-workspace = true
+# Cannot inherit workspace lints since overriding them is not supported yet: https://github.com/rust-lang/cargo/issues/13157
+# [lints]
+# workspace = true
+# 
+# Differences from the workspace lints have comments explaining why they are different
+
+[lints.rust]
+missing_docs = "warn"
+unsafe_op_in_unsafe_fn = "forbid"
+
+[lints.clippy]
+# Lint Groups
+all = "deny"
+pedantic = "warn"
+nursery = "warn"
+cargo = "warn"
+# Individual Lints
+multiple_unsafe_ops_per_block = "forbid"
+undocumented_unsafe_blocks = "forbid"
+# unnecessary_safety_doc = "forbid"
+unnecessary_safety_doc = "deny" # This is lowered to deny to allow overriding it for proc_macros: https://github.com/rust-lang/rust-clippy/issues/12583
+
+[lints.rustdoc]
+bare_urls = "warn"
+broken_intra_doc_links = "warn"
+invalid_codeblock_attributes = "warn"
+invalid_html_tags = "warn"
+invalid_rust_codeblocks = "warn"
+missing_crate_level_docs = "warn"
+private_intra_doc_links = "warn"
+redundant_explicit_links = "warn"
+unescaped_backticks = "warn"

crates/wdk-macros/tests/integration_tests.rs

@@ -24,7 +24,8 @@ lazy_static! {
     static ref MACROTEST_INPUT_FOLDER_PATH: PathBuf = INPUTS_FOLDER_PATH.join("macrotest");
     static ref TRYBUILD_INPUT_FOLDER_PATH: PathBuf = INPUTS_FOLDER_PATH.join("trybuild");
     static ref OUTPUTS_FOLDER_PATH: PathBuf = TESTS_FOLDER_PATH.join("outputs");
-    static ref TOOLCHAIN_SPECIFIC_OUTPUTS_FOLDER_PATH: PathBuf = OUTPUTS_FOLDER_PATH.join(TOOLCHAIN_CHANNEL_NAME);
+    static ref TOOLCHAIN_SPECIFIC_OUTPUTS_FOLDER_PATH: PathBuf =
+        OUTPUTS_FOLDER_PATH.join(TOOLCHAIN_CHANNEL_NAME);
     static ref MACROTEST_OUTPUT_FOLDER_PATH: PathBuf =
         TOOLCHAIN_SPECIFIC_OUTPUTS_FOLDER_PATH.join("macrotest");
     static ref TRYBUILD_OUTPUT_FOLDER_PATH: PathBuf =

crates/wdk-sys/Cargo.toml

@@ -33,5 +33,37 @@ default = []
 nightly = ["wdk-macros/nightly"]
 test-stubs = []
 
-[lints]
-workspace = true
+# Cannot inherit workspace lints since overriding them is not supported yet: https://github.com/rust-lang/cargo/issues/13157
+# [lints]
+# workspace = true
+# 
+# Differences from the workspace lints have comments explaining why they are different
+
+[lints.rust]
+missing_docs = "warn"
+# unsafe_op_in_unsafe_fn = "forbid"
+unsafe_op_in_unsafe_fn = "deny" # This is lowered to deny so that we can opt out of it for generated code
+
+[lints.clippy]
+# Lint Groups
+all = "deny"
+pedantic = "warn"
+nursery = "warn"
+cargo = "warn"
+# Individual Lints
+# multiple_unsafe_ops_per_block = "forbid"
+multiple_unsafe_ops_per_block = "deny" # This is lowered to deny so that we can opt out of it for generated code
+# undocumented_unsafe_blocks = "forbid"
+undocumented_unsafe_blocks = "deny" # This is lowered to deny so that we can opt out of it for generated code
+unnecessary_safety_doc = "forbid"
+
+[lints.rustdoc]
+bare_urls = "warn"
+broken_intra_doc_links = "warn"
+invalid_codeblock_attributes = "warn"
+invalid_html_tags = "warn"
+invalid_rust_codeblocks = "warn"
+missing_crate_level_docs = "warn"
+private_intra_doc_links = "warn"
+redundant_explicit_links = "warn"
+unescaped_backticks = "warn"

crates/wdk-sys/build.rs

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation
 // License: MIT OR Apache-2.0
 
+//! Build script for the `wdk-sys` crate.
+
 use std::{
     env,
     path::{Path, PathBuf},

crates/wdk/build.rs

@@ -1,6 +1,8 @@
 // Copyright (c) Microsoft Corporation
 // License: MIT OR Apache-2.0
 
+//! Build script for the `wdk` crate.
+
 fn main() -> Result<(), wdk_build::ConfigError> {
     // Re-export config from wdk-sys
     Ok(wdk_build::Config::from_env_auto()?.export_config()?)

crates/wdk/src/wdf/spinlock.rs

@@ -2,9 +2,6 @@ use wdk_sys::{macros, NTSTATUS, WDFSPINLOCK, WDF_OBJECT_ATTRIBUTES};
 
 use crate::nt_success;
 
-// private module + public re-export avoids the module name repetition: https://github.com/rust-lang/rust-clippy/issues/8524
-#[allow(clippy::module_name_repetitions)]
-
 /// WDF Spin Lock.
 ///
 /// Use framework spin locks to synchronize access to driver data from code that

crates/wdk/src/wdf/timer.rs

@@ -2,9 +2,6 @@ use wdk_sys::{macros, NTSTATUS, WDFTIMER, WDF_OBJECT_ATTRIBUTES, WDF_TIMER_CONFI
 
 use crate::nt_success;
 
-// private module + public re-export avoids the module name repetition: https://github.com/rust-lang/rust-clippy/issues/8524
-#[allow(clippy::module_name_repetitions)]
-
 /// WDF Timer.
 pub struct Timer {
     wdf_timer: WDFTIMER,