chore: Bump windows from 0.52.0 to 0.56.0 (#144)

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Melvin Wang <[email protected]>
microsoft · May 3, 2024 · 66c6b16 · 66c6b16
1 parent 2f5215a
commit 66c6b16
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 7 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/wdk-build/Cargo.toml b/crates/wdk-build/Cargo.toml
@@ -16,7 +16,7 @@ serde_json.workspace = true
 clap = { version = "4.5.4", features = ["derive"] }
 clap-cargo = "0.14.0"
 thiserror = "1.0.59"
-windows = { version = "0.52.0", features = [
+windows = { version = "0.56.0", features = [
   "Win32_Foundation",
   "Win32_System_Registry",
 ] }
@@ -26,7 +26,7 @@ cargo_metadata = "0.18.1"
 rustversion = "1.0.15"
 
 [dev-dependencies]
-windows = { version = "0.52.0", features = ["Win32_UI_Shell"] }
+windows = { version = "0.56.0", features = ["Win32_UI_Shell"] }
 
 # Cannot inherit workspace lints since overriding them is not supported yet: https://github.com/rust-lang/cargo/issues/13157
 # [lints]

diff --git a/crates/wdk-build/src/utils.rs b/crates/wdk-build/src/utils.rs
@@ -217,6 +217,7 @@ fn read_registry_key_string_value(
                 // SAFETY: `opened_key_handle` is valid opened key that was opened by
                 // `RegOpenKeyExA`
                 unsafe { RegCloseKey(opened_key_handle) }
+                    .ok()
                     .expect("opened_key_handle should be successfully closed");
                 return Some(
                     CStr::from_bytes_with_nul(&buffer[..len as usize])
@@ -235,7 +236,8 @@ fn read_registry_key_string_value(
         // SAFETY: `opened_key_handle` is valid opened key that was opened by
         // `RegOpenKeyExA`
         unsafe { RegCloseKey(opened_key_handle) }
-            .expect(r"opened_key_handle should be successfully closed");
+            .ok()
+            .expect("opened_key_handle should be successfully closed");
     }
     None
 }