[Fix] Log stream delay when dir does not exist #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaMor
force-pushed
the
fix-file-monitor-log-stream
branch
from
ed1ea40 to
aaf6953
Compare
profnandaa
previously approved these changes
May 22, 2024
TinaMor
force-pushed
the
fix-file-monitor-log-stream
branch
3 times, most recently
from
1acced4 to
fc52e3d
Compare
TinaMor
force-pushed
the
fix-file-monitor-log-stream
branch
from
fc52e3d to
3fb1ee3
Compare
billywr
approved these changes
May 23, 2024
|
|
profnandaa
approved these changes
May 23, 2024
| class LogFileMonitor final | ||
| { | ||
| public: | ||
| LogFileMonitor() = delete; | ||
|
|
||
| LogFileMonitor( | ||
| _In_ const std::wstring& LogDirectory, | ||
| _In_ const std::wstring& Filter, | ||
| _In_ const std::wstring &LogDirectory, |
There was a problem hiding this comment.
nitpick: I think the & should right after the type as per common convention; T&?
bobsira
approved these changes
May 23, 2024
CharityKathure
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes LogMonitor tool missing the first few log lines when the log file and directory are created after the LogMonitor tool has started. Issue #170
This regression is caused by the PR #149. The WaitForMultipleObjects() function waits until the timer expires even though the object is already created during the wait interval.
Summary of Fix
The fix adds a waitable object on the directory that the LogMonitor tool is observing. The WaitForMultipleObjects() function waits until either the timer expires or the specified file is created. By including the handle of the waitable object in the array, the function can return as soon as the file is created.
This way, the system does not have to wait for the entire duration specified by the timer if the file is created during the wait period. This makes the file monitoring more responsive and efficient.