Signal Handling: Set up a signal handler for common catastrophic failure signals #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2023 19:08
TinaMor
reviewed
Jan 8, 2024
bobsira
reviewed
Jan 16, 2024
Comment on lines
+276
to
+279
| setSignalHandler(SIGSEGV, signalHandler); // Segmentation fault | ||
| setSignalHandler(SIGFPE, signalHandler); // Floating point exception | ||
| setSignalHandler(SIGILL, signalHandler); // Illegal instruction | ||
| setSignalHandler(SIGABRT, signalHandler); // Abort |
There was a problem hiding this comment.
This looks good to me. There are more signals like SIGBUS and SIGPIPE etc that might cause catastrophic failures do you reckon we should include them? Also you can think if we can capture more info when we have such failures. At the moment we are only logging the signal type. It is possbile to log info like timestamp, stack trace when we have these signals?
There was a problem hiding this comment.
Using the TraceError function to log the catastrophic failure ensures that timestamp is captured:
bobsira
approved these changes
Jan 16, 2024
TinaMor
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing (simulating catastrophic failure):