Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support iobinding for Whisper Base demo on WebNN GPU #67

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support iobinding for Whisper Base demo on WebNN GPU #67

wants to merge 2 commits into from

Conversation

miaobin
Copy link

@miaobin miaobin commented Nov 29, 2024 •
edited by fdwr
Loading

⛔ Do not merge until models are uploaded https://huggingface.co/microsoft/whisper-base-webnn/tree/main

This change will bring about 50% improvement to the Whisper Base demo on the WebNN GPU backend.
PTAL, @ibelem @fdwr

@ibelem
Copy link
Contributor

ibelem commented Nov 29, 2024 •
edited
Loading

Thanks @miaobin for the improvements! @fdwr Please note that this pull request requires two models to be uploaded to the specified Hugging Face repository at https://huggingface.co/microsoft/whisper-base-webnn/tree/main @Adele101 :

@miaobin miaobin changed the title Support iobinding for Whisper Base demo Support iobinding for Whisper Base demo on WebNN GPU Nov 29, 2024
fdwr
fdwr approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks Bin. I'll defer until the model is uploaded before merging.

demos/whisper-base/main.js Outdated Show resolved Hide resolved
demos/whisper-base/main.js Outdated Show resolved Hide resolved
demos/whisper-base/whisper.js Outdated Show resolved Hide resolved
@miaobin
Copy link
Author

miaobin commented Dec 5, 2024

Updated the code to reach the comments. Please take another look, thanks a lot!

fdwr
fdwr approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Collaborator

fdwr commented Dec 6, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Collaborator

fdwr commented Dec 6, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Collaborator

fdwr commented Dec 6, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Collaborator

fdwr commented Dec 6, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

Honry
Honry approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@fdwr
Copy link
Collaborator

fdwr commented Dec 17, 2024

@Adele101 - do you have permission to upload the models?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Honry Honry Honry approved these changes

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miaobin @ibelem @fdwr @Honry