Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum required driver version messaging in samples #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jgw96
Copy link
Contributor

@jgw96 jgw96 commented Aug 19, 2024

Following the existing patterns, I have added a driver info utility to the site.

Things I am unsure of:

  • Do stable diffusion and segment-anything have compatible driver versions? I couldn't find those in the table
  • Is the layout for the driver info, specifically how Qualcomm and Intel are displayed next to each other ok?

@fdwr
Copy link
Collaborator

fdwr commented Aug 19, 2024

FYI @ibelem.

@fdwr
Copy link
Collaborator

fdwr commented Aug 19, 2024

Do stable diffusion and segment-anything have compatible driver versions?

Nope, no NPU's currently support them (memory limits).

Is the layout for the driver info, specifically how Qualcomm and Intel are displayed next to each other ok?

Do you have a local screenshot of what that would look like? (I can read CSS, but seeing is knowing)

@fdwr fdwr requested a review from Adele101 August 19, 2024 23:27
@fdwr fdwr changed the title feat(): driver version utility Add minimum required driver version messaging in samples Aug 19, 2024
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the GPU driver version and NPU driver version can differ (and this is particularly for the NPU version), can we separate them, maybe even make this conditionally dependent on whether the GPU vs NPU button is selected? (or the URL has deviceType= in it) Thanks.

@ibelem
Copy link
Contributor

ibelem commented Aug 20, 2024

@jgw96 @fdwr Maybe we can list NPU driver versions only when devicetype=npu in the URL, otherwise list GPU driver versions?

When necessary, we can detect arm or x86 for Windows to show Qualcomm or Intel driver only.
https://learn.microsoft.com/en-us/microsoft-edge/web-platform/how-to-detect-win11#sample-code-for-detecting-arm-or-x86

@jgw96
Copy link
Contributor Author

jgw96 commented Aug 20, 2024

@jgw96 @fdwr Maybe we can list NPU driver versions only when devicetype=npu in the URL, otherwise list GPU driver versions?

When necessary, we can detect arm or x86 for Windows to show Qualcomm or Intel driver only. https://learn.microsoft.com/en-us/microsoft-edge/web-platform/how-to-detect-win11#sample-code-for-detecting-arm-or-x86

Yeah I like this, Ill go with this solution

@fdwr
Copy link
Collaborator

fdwr commented Nov 9, 2024

Time to resurrect this one? FYI @Adele101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants