Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16 #17 Add outputDataType option for the ArgMax/ArgMin ops #19

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

ibelem
Copy link
Contributor

@ibelem ibelem commented Jul 23, 2024

This PR included test packages of required WebNN EP fixes for #16 #17:

  1. [WebNN EP] Add outputDataType option for the ArgMax/ArgMin ops onnxruntime#21385 Add outputDataType option for the ArgMax/ArgMin ops
  2. argMax/Min only support scalar axis in TFLite runtime webmachinelearning/webnn#629 argMax/Min only support scalar axis in TFLite runtime
  3. ArgMax/Min selectLastIndex is not supported on CoreML webmachinelearning/webnn#652 ArgMax/Min selectLastIndex is not supported on CoreML
  4. Einsum for Segment Anything demo

Other changes:

  1. Removed powerPreference: "default" in application code since 353552552 (CL 5716629 will be landed later)
SD 1.5 SA
Chrome Canary 128.0.6612.0 Fail SAM ViT-B Decoder (FP16) Fail
Chrome Canary 128.0.6613.5 Fail SAM ViT-B Decoder (FP16) Fail
Chrome Dev 128.0.6601.2 Fail SAM ViT-B Decoder (FP16) Fail

The 5721028 fix is not in Canary 128.0.6613.5, need to wait new Canary build to test.

@ibelem
Copy link
Contributor Author

ibelem commented Jul 24, 2024

The 129.0.6614.0 included the merged CL 5721028 - 128.0.6613.5 / 129.0.6614.0

SD 1.5 SA
Chrome Canary 128.0.6613.5 Fail SAM ViT-B Decoder (FP16) Fail
Chrome Canary 129.0.6614.0 PASS PASS

The SD Turbo (Text Encoder) mode failed to run with WebNN EP of ONNX Runtime Web 1.18 on the new 129.0.6614.0 build, so upgraded the EP to internal build for SD Turbo as well in 41f5e1e (#19). @miaobin @Honry

@fdwr PTAL

@fdwr
Copy link
Collaborator

fdwr commented Jul 24, 2024

PTAL

👀 Will before I leave today. Thank you Belem.

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

demos/sd-turbo/index.js Show resolved Hide resolved
@fdwr
Copy link
Collaborator

fdwr commented Jul 25, 2024

Please do not merge this PR yet

Let me know when to merge it. (I moved the text buried in the middle of the text to the top of the description in case Adele tries to merge it).

@ibelem
Copy link
Contributor Author

ibelem commented Jul 25, 2024

@fdwr It can be merged, as i've tested them pass on 129.0.6614.0 later yesterday. Thanks! @Adele101

@fdwr fdwr merged commit c52e0c4 into microsoft:main Jul 25, 2024
1 check passed
@ibelem ibelem deleted the outputdatatype branch September 25, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants