Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coffeescript] Fix coffeescript parse bug #5119

Closed
wants to merge 1 commit into from
Closed

[Coffeescript] Fix coffeescript parse bug #5119

wants to merge 1 commit into from

Conversation

vedanshujain
Copy link

Fixes #499

@msftclas
Copy link

msftclas commented Apr 9, 2016

Hi @vedanshujain, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Apr 9, 2016

@vedanshujain, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@vedanshujain vedanshujain changed the title [Coffeescript] Fix coffeescrupt parse bug https://github.com/Microsof… [Coffeescript] Fix coffeescrupt parse bug Apr 9, 2016
@vedanshujain
Copy link
Author

This fixes #499

@vedanshujain vedanshujain changed the title [Coffeescript] Fix coffeescrupt parse bug [Coffeescript] Fix coffeescript parse bug Apr 9, 2016
@vedanshujain
Copy link
Author

@aeschli Hey, I noticed you added tokeniser tests for coffee.. Do you want me to add this specific case and some more there as well (If you are not planning to do it yourself)?

@aeschli
Copy link
Contributor

aeschli commented Apr 11, 2016

@vedanshujain Thanks a lot for the fix suggestion. I uses a slightly different approach (with a look ahead). See issue #499.
Thanks anyway for your help.

@aeschli aeschli closed this Apr 11, 2016
@vedanshujain
Copy link
Author

@aeschli thanks.. looks good

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[coffeescript] syntax highlighting broken when divide symbol is not separated using space
3 participants