EditContext: Removing the text area dom node on disposal #234419
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiday-mar
changed the title
Tyriar
approved these changes
Nov 22, 2024
Comment on lines
168
to
171
| this.domNode.domNode.blur(); | ||
| this.domNode.domNode.remove(); | ||
| this.textArea.domNode.remove(); | ||
| super.dispose(); |
There was a problem hiding this comment.
nit: I prefer this approach so we don't need to override:
this._register(toDisposable(() => {
// Force blue the dom node so can write in pane with no native edit context after disposal
this.domNode.domNode.blur();
this.domNode.domNode.remove();
this.textArea.domNode.remove();
}));
There was a problem hiding this comment.
Ah yep thanks for the advice, indeed it removes the override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polish