change go to symbol in workspace shortcut to Include ALT #234243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TylerLeonhardt could you please check this? Also, I tried to see if there are any existing tests that might be breaking, but I found that there are none. |
jrieken
requested changes
Nov 20, 2024
There was a problem hiding this comment.
I like the intention of this change but this PR would change it for all platforms, e.g also desktop is not wanted.
The way to tackle this is to have another keybinding that is guarded with a isWebContext context key
|
Additionally, the proposal in this PR would have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #232381
Included
Alt(option) forGo to Symbol in Workspace