Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Add devcontainer definition for k3d kubernetes cluster (minikube alternative) #1456

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

kforeverisback
Copy link

@kforeverisback kforeverisback commented May 18, 2022

Description

Add a new devcontainer definition for k3d kubernetes cluster.

With this, user will be able to create a new devcontainer which will enable the creation of a local kubernetes cluster (automated or manual).

This PR is based off of kubernetes-helm-minikube dev container.

PR Checklist

  • I have updated the documentation accordingly.
    • Added README.md describing the container
    • Added sample nginx deployment document in README.md
  • I have added/updated tests to cover my changes.
    • Changed test.sh under test-project directory
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • Lint checker not integrated but fixed most Markdown and devcontainer.json lint errors (followed existing container document format)

Does this introduce a breaking change?

  • Yes
  • No

Testing

  • Manually created Codespaces from .devcontainer
    • Provisioned a k3d cluster from terminal
    • Automatically provisioned k3d cluster in postStartCommand
  • Manually created local devcontainer
    • Provisioned a k3d cluster from terminal afterwards
    • Automatically provisioned k3d cluster in postStartCommand
  • Manually applied pods/deployments to verify k3d cluster

Isse Closes/Fixes

@kforeverisback
Copy link
Author

@iamnicoj @sivamu @juzuluag

@bamurtaugh
Copy link
Member

Thanks so much for this contribution!

As a heads up, we're working on how to best support current and future contributions to this repo. As this poses a delay in accepting some new definitions, we want to emphasize we really appreciate your work, and we're working on how to best support contributions in a scalable way moving forward. There are additional details in this issue: #1291.

@bamurtaugh
Copy link
Member

Thanks again for opening this PR!

As a heads up, our team has been actively focused on an updated plan for community contributions and this repo moving forward, which we've now outlined in this issue: #1589. This includes moving to a couple new repos for images (https://github.com/devcontainers/images) and Features (https://github.com/devcontainers/features).

We anticipate to have a similar repo and distribution process for templates/definitions. We'll keep everyone updated (likely via another issue in this repo or comment on #1589) when our new templates repo is available and the process is defined.

Please let me know if you have any questions, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add container definition for k3d cluster
4 participants