Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphene] remove arm & windows exclusion #43335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sargunv
Copy link

@sargunv sargunv commented Jan 17, 2025

I installed with with --allow-unsupported on a Windows ARM laptop and it worked fine:

vcpkg install gtk --allow-unsupported --recurse

(graphene is a dependency of gtk)

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

I installed with with --allow-unsupported on a Windows ARM laptop and it worked fine:

```
vcpkg install gtk --allow-unsupported --recurse
```

(graphene is a dependency of gtk)
@BillyONeal
Copy link
Member

BillyONeal commented Jan 17, 2025

https://dev.azure.com/vcpkg/public/_build/results?buildId=111603 failed to build gtk on arm64, so I submitted a change restoring a block for that. However:

I installed with with --allow-unsupported on a Windows ARM laptop and it worked fine:

vcpkg install gtk --allow-unsupported --recurse

(graphene is a dependency of gtk)

If getting gtk to work is what you actually want you might need to investigate the failures there. I think this PR which moves the supports expression 'up' to gtk and thus tests graphene and its dependencies on ARM is an improvement that would be good to take on its own though.

@sargunv
Copy link
Author

sargunv commented Jan 18, 2025

Interesting, gtk built just fine on my arm device.

Will take a look at those failures

@sargunv
Copy link
Author

sargunv commented Jan 18, 2025

Thanks for dealing with the version bits, I wasn't sure what to do and was going to look into it later

@sargunv sargunv marked this pull request as ready for review January 18, 2025 00:15
@LilyWangLL LilyWangLL self-assigned this Jan 20, 2025
@LilyWangLL LilyWangLL changed the title graphene: remove arm & windows exclusion [graphene] remove arm & windows exclusion Jan 20, 2025
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 20, 2025
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants