Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llnl-units] Add new port #37417

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Conversation

petersteneteg
Copy link
Contributor

Adds the https://github.com/LLNL/units units library.

It's named llnl-units, to avoid conflicts, this has upstream support see LLNL/units#164

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@petersteneteg petersteneteg changed the title Add llnl units [llnl-units] Add new port Mar 13, 2024
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 14, 2024
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows(header files found):

llnl-units provides CMake targets:

    find_package(llnl-units CONFIG REQUIRED)
    target_link_libraries(main PRIVATE llnl-units::units)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Mar 15, 2024
@BillyONeal BillyONeal merged commit c2f0f57 into microsoft:master Mar 16, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the new port!

@petersteneteg petersteneteg deleted the add-llnl-units branch March 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants