Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amqpcpp] Update to 4.3.23 #31271

Merged

Conversation

MonicaLiu0311
Copy link
Contributor

Fixes #31177.

  • Update amqpcpp to 4.3.23.
  • Errors C2589 and C2059 occurred during testing usage, add fix-max_min_macros.patch to fix it. Reported upstream: AMQP-CPP/issues/498.
    E:\vcpkg01\installed\x64-windows\include\amqpcpp\message.h(85,42): error C2589: '(': illegal token on right side of '::' 
    E:\vcpkg01\installed\x64-windows\include\amqpcpp\message.h(85,42): error C2059: syntax error: ')' 
    
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

No feature needs to be tested. The usage test passed (header files found):

amqpcpp provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(amqpcpp CONFIG REQUIRED)
    target_link_libraries(main PRIVATE amqpcpp)

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels May 5, 2023
@MonicaLiu0311 MonicaLiu0311 added the depends:upstream-changes Waiting on a change to the upstream project label May 6, 2023
@MonicaLiu0311
Copy link
Contributor Author

Unresponsive from upstream, so go ahead with this PR.

@MonicaLiu0311 MonicaLiu0311 removed the depends:upstream-changes Waiting on a change to the upstream project label May 15, 2023
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review May 15, 2023 09:34
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 15, 2023
@JavierMatosD JavierMatosD merged commit 1c5636c into microsoft:master May 15, 2023
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/update_amqpcpp branch May 16, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[amqpcpp] update to 4.3.23
3 participants