Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Support for Family SAML21 #83

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

sabas1080
Copy link
Contributor

@sabas1080 sabas1080 commented Nov 7, 2019

Hi I have started the port for the SAML family

so far the UF2 file can be generated, but

  • the flag -nostartfiles must be removed in Makefiles
  • I can't test hardware until next week

I wait for your feedback, thanks

fixes #82

@tannewt tannewt requested a review from mmoskal November 11, 2019 06:09
Copy link
Member

@mmoskal mmoskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo requested changes!

inc/uf2format.h Outdated Show resolved Hide resolved
scripts/saml21j18b_self.ld Outdated Show resolved Hide resolved
src/flash_saml21.c Show resolved Hide resolved
Copy link
Member

@mmoskal mmoskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above, meant to request changes

Makefile Show resolved Hide resolved
@mmoskal
Copy link
Member

mmoskal commented Nov 12, 2019

Let me know when you have tested on hardware!

@sabas1080 sabas1080 mentioned this pull request Nov 12, 2019
@sabas1080
Copy link
Contributor Author

@mmoskal tested in hardware and ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Family SAML?
3 participants