-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for named unions in protobuf emitter #4450
base: main
Are you sure you want to change the base?
Conversation
@joerosenberg please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
b90fd3e
to
0289e18
Compare
0289e18
to
cf53a23
Compare
…ecorator check in validateUnion as it's now covered in validateFieldDecorations
fix #1854
This still needs more test coverage before merging, and I don't believe reserved field decorators are handled yet.