Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: OpenAPI3 creating conflicting type declaration when type was used in multipart implicit body and json body. #2752

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Dec 13, 2023

fix #2751

Problem was when we reduce the context it is a patch not a replace so if we delete the contentType to have the default handling then it would keep the previous value instead of actually removing it.

Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2752/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2752/

@markcowl
Copy link
Contributor

@timotheeguerin Hey, do we need to update the core dependency in the release branch for typespec-azure?

@timotheeguerin
Copy link
Member Author

@timotheeguerin Hey, do we need to update the core dependency in the release branch for typespec-azure?

nope all fixes are independendent

@timotheeguerin timotheeguerin merged commit 85343de into microsoft:release/dec-2023 Dec 13, 2023
12 checks passed
@timotheeguerin timotheeguerin deleted the hotfix/openapi3-multipart-conflict branch December 13, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants