VSCode extension: Use rollup for dev build too #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
daviwil,
markcowl and
allenjzhang
as code owners
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2730/ |
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2730/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2730/ |
bterlson
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem is vscode still doesn't allow loading es modules so we had all those hacks to make it work but loading es modules from comon js is always problematic. Using rollup to generate a commonjs output solve the problem and we are using that for the published version just not in dev. Issue with this new approach is
rush watchwon't build the extension but that's also not something you often need to touch.