Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workflow for codeql configuration #2720

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Dec 4, 2023

Somehow the default UI configuration doesn't run on pull requests so hopefully this will work.

Right now we just get the security warnings after merging which is unfortunate. It is also hard to run codeql locally so having it on a PR to make sure we resolve it is nice

We'll get error like that
image

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2720/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2720/

@timotheeguerin timotheeguerin enabled auto-merge (squash) December 4, 2023 19:14
@timotheeguerin timotheeguerin merged commit f646e19 into main Dec 5, 2023
12 checks passed
@timotheeguerin timotheeguerin deleted the codeql-as-workflow branch December 5, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants