Fix issue with operation parameter versioning #2691
Conversation
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2691/ |
tjprescott
force-pushed
the
versioning/OpParams
branch
from
2abc7c1
to
becbf6f
Compare
tjprescott
force-pushed
the
versioning/OpParams
branch
from
becbf6f
to
1d40bd5
Compare
tjprescott
requested review from
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
| if (paramAvailability !== undefined) { | ||
| validateAvailabilityForContains( | ||
| program, | ||
| operationAvailability, | ||
| paramAvailability, | ||
| operation, | ||
| parameter | ||
| ); | ||
| } else if (paramTypeAvailability !== undefined) { | ||
| validateAvailabilityForRef( | ||
| program, | ||
| operationAvailability, | ||
| paramTypeAvailability, | ||
| operation, | ||
| parameter.type | ||
| ); | ||
| } |
There was a problem hiding this comment.
For this to work, I would actually need to build the availability map based on ALL references in the spec, which would be considerably more design and implementation effort. The new test showcases the problem. Thus, I've just removed this check.
| @added(Versions.v2) | ||
| age: Foo; | ||
| } | ||
|
|
||
| @added(Versions.v1) | ||
| op oldOp(...Parameters): void; | ||
|
|
||
| @added(Versions.v3) | ||
| op newOp(...Parameters): void; |
There was a problem hiding this comment.
This is the crux of issue #2688. While this appears to be an error just looking at Parameters and newOp, it makes sense when you consider the existence of oldOp.
Fixes #2688.