-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI3: emit all properties for unreferenced schemas #2620
OpenAPI3: emit all properties for unreferenced schemas #2620
Conversation
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2620/ |
c092e46
to
2c7ba30
Compare
bdc2c14
to
05b285b
Compare
packages/samples/test/output/visibility/@typespec/openapi3/openapi.yaml
Outdated
Show resolved
Hide resolved
fee2115
to
db6e656
Compare
3ac7a5c
to
fed834d
Compare
bfab436
to
35e58c8
Compare
Investigating the weird cause of the "DeleteOrCreateOrUpdateOrReadItem" suffixes. It seems to be a very edgy edge case... |
85b0f1d
to
52310e8
Compare
24fc7f7
to
f251fe0
Compare
@@ -112,7 +114,7 @@ components: | |||
relatives: | |||
type: array | |||
items: | |||
$ref: '#/components/schemas/PersonRelative' | |||
$ref: '#/components/schemas/PersonRelativeReadOrCreateOrUpdateOrDeleteItem' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are, per our discussion, the appropriate names.
1fd2abd
to
bf7e182
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis, this looks great, can we try this out in the rest-api-specs repo to see how many specs are affected?
@markcowl here's the link to the REST API specs test PR: |
@markcowl the REST API specs pass with this change: |
bf7e182
to
523cd1d
Compare
523cd1d
to
8f85ebd
Compare
8f85ebd
to
f4440b5
Compare
Fix #2571.
BREAKING CHANGE: Since the previous behavior was to emit unreferenced schemas with Read visibility, this change can produce a breaking change in Swagger if unreferenced schemas were previously emitted that had write visibility properties stripped.