Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useRef decorator #2243

Merged
merged 5 commits into from
Aug 7, 2023

Conversation

timotheeguerin
Copy link
Member

fix #2239

useRef decorator in openapi3 library was missing valueof for ref paramater which led to it saving the StringLiteral object instead of the actual ref string.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2243/

Website: https://cadlwebsite.z1.web.core.windows.net/prs/2243/

Copy link
Contributor

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link an uptake PR for TypeSpec-azure?

I want to make sure there it no impact there, otherwise, this looks great.

@timotheeguerin timotheeguerin enabled auto-merge (squash) August 7, 2023 19:58
@timotheeguerin timotheeguerin merged commit 668a763 into microsoft:main Aug 7, 2023
11 checks passed
@timotheeguerin timotheeguerin deleted the fix/openapi3-use-ref branch August 8, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share Open API type across specs
2 participants