Emitter framework async source file #2183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted this part of the breaking change from #2157
With prettier 3.0.0 the formatter is async. Which requires the emitter framework to provide a way to deal with async content mutation.
This only breaks in the emitter framework is calling
this.emitter.emitSourceFile
directly which would happen if you wrote a customwriteOutput
. If usage only includesourceFile
override then it still allows returning a non promise.