Add support for enum member references to emitter framework #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bterlson
requested review from
daviwil,
nguerrera,
markcowl,
allenjzhang and
timotheeguerin
as code owners
bterlson
changed the title
nguerrera
approved these changes
Jun 29, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emitter framework did not handle enum member references. This PR adds support for them in the emitter framework (following a similar pattern to model references). It also adds support for them in the JSON Schema emitter, which simply emits the value inline (rather than doing any magic with $ref + json paths, which seems overkill).
Fixes #2135.