Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatter incorrectly formatting meta type accessor #2126

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Fix formatter incorrectly formatting meta type accessor #2126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bf2e29
Fix formatter incorrectly formatting meta type accessor
timotheeguerin Jun 28, 2023
7a02678
Changelog
timotheeguerin Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@typespec/compiler/fix-formatter-format-meta-accessor_2023-06-28-15-30.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@typespec/compiler",
"comment": "Fix: Formatter incorrectly formatting `::` to `.`",
"type": "none"
}
],
"packageName": "@typespec/compiler"
}
3 changes: 2 additions & 1 deletion packages/compiler/src/formatter/print/printer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,8 @@ export function printMemberExpression(
print: PrettierChildPrint
): Doc {
const node = path.getValue();
return [node.base ? [path.call(print, "base"), "."] : "", path.call(print, "id")];

return [node.base ? [path.call(print, "base"), node.selector] : "", path.call(print, "id")];
}

export function printModelExpression(
Expand Down
13 changes: 13 additions & 0 deletions packages/compiler/test/formatter/formatter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2265,6 +2265,19 @@ model Foo {
});
});

describe("meta type accessor", () => {
it("format with ::", () => {
assertFormat({
code: `
@@doc(myOp :: parameters.foo, "")
`,
expected: `
@@doc(myOp::parameters.foo, "");
`,
});
});
});

describe("projections", () => {
it("format projections", () => {
assertFormat({
Expand Down
Loading