Adding versioning check for TypeSpec init template #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenjzhang
requested review from
bterlson,
daviwil,
nguerrera,
markcowl and
timotheeguerin
as code owners
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/2121/ |
packages/compiler/src/init/init.ts
Outdated
| @@ -286,7 +287,10 @@ async function validateTemplate(template: any, templatesUrl: TemplatesUrl): Prom | |||
| const validationTarget = templatesUrl.file as SourceFile; | |||
| let validationResult: ValidationResult; | |||
| // 1. If current version > minimumCompilerVersion, proceed with strict validation | |||
| if (template.minimumCompilerVersion && currentCompilerVersion > template.minimumCompilerVersion) { | |||
| if ( | |||
| template.minimumCompilerVersion && | |||
There was a problem hiding this comment.
if we using semver pacakge do we maybe just want to leave that as a semver range(>=0.45.0) and rename to compilerVersion
There was a problem hiding this comment.
I like the rename. Not sure about "leave that" means. compilerVersion default value as ">=0.46.0" ?
nguerrera
reviewed
Jul 5, 2023
nguerrera
approved these changes
Jul 5, 2023
| function logDiagnostics(diagnostics: readonly Diagnostic[]): void { | ||
| diagnostics.forEach((diagnostic) => { | ||
| // eslint-disable-next-line no-console | ||
| console.log(diagnostic.message); |
There was a problem hiding this comment.
Do we consider the rest of the diagnostic, code/severity not useful here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: