Fix: @withVisibility decorator (#2544)

fix #2517
microsoft · Oct 13, 2023 · f110040 · f110040
1 parent e762230
commit f110040
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/common/changes/@typespec/compiler/fix-with-visibility_2023-10-06-00-26.json b/common/changes/@typespec/compiler/fix-with-visibility_2023-10-06-00-26.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@typespec/compiler",
+      "comment": "Fix: Properties filtered with `@withVisibility` will have their visibility removed. This prevent visibility from being applied twice and rendering invalid models",
+      "type": "none"
+    }
+  ],
+  "packageName": "@typespec/compiler"
+}
diff --git a/packages/compiler/src/lib/decorators.ts b/packages/compiler/src/lib/decorators.ts
@@ -811,12 +811,17 @@ export function getVisibility(program: Program, target: Type): string[] | undefi
   return program.stateMap(visibilitySettingsKey).get(target);
 }
 
+function clearVisibilities(program: Program, target: Type) {
+  program.stateMap(visibilitySettingsKey).delete(target);
+}
+
 export function $withVisibility(
   context: DecoratorContext,
   target: Model,
   ...visibilities: string[]
 ) {
   filterModelPropertiesInPlace(target, (p) => isVisible(context.program, p, visibilities));
+  [...target.properties.values()].forEach((p) => clearVisibilities(context.program, p));
 }
 
 export function isVisible(