-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BRIGHT dataset #2520
base: main
Are you sure you want to change the base?
Add BRIGHT dataset #2520
Conversation
torchgeo/datasets/bright.py
Outdated
# https://github.com/ChenHongruixuan/BRIGHT/blob/11b1ffafa4d30d2df2081189b56864b0de4e3ed7/dfc25_benchmark/dataset/make_data_loader.py#L101 | ||
# post image is stacked to also have 3 channels | ||
post_image = repeat(post_image, 'c h w -> (repeat c) h w', repeat=3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, does this make sense? Is this only because they want to use RGB models pre-trained on ImageNet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now that we are implementing this as the "Challenge" version of the dataset it's okay to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. If we want to use one of our S1 pretrained models, not duplicating may make more sense. I would personally leave it up to the user to add a transform if they want this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm still against this. It would prevent us from using our S1 pretrained models on S1 imagery.
Hi @nilsleh , Thank you very much for your contribution and efforts in integrating BRIGHT into torchgeo! We are a little hesitant to include the txt file you mentioned into this for torchgeo, as that is only for the DFC25 division. That's why we provide these txt files in github instead of original dataset zip file, especially considering that the current BRIGHT is not final version. Best, |
Thanks for getting back @ChenHongruixuan , no problem, we can also host them on our torchgeo Hugginface, just to make downloading more easier. Also very much looking forward to the final version of the dataset. Feel free to let me know when that is openly available, such that we can integrate support for that as well here. |
@nilsleh , thank you so much for your support!! |
Co-authored-by: Adam J. Stewart <[email protected]>
This PR adds the BRIGHT dataset.
Dataset Features:
Dataset Format:
@ChenHongruixuan @olidietrich Thank you for the nice work and making the dataset public. I was wondering whether you could include the split .txt files found here inside the zip file on Huggingface such that everything is in one place? And of course if you have any other comments about the PR, feel free to let us know below.