Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a new resource ResourceServiceEndpointProjectPermissions #1031 #1051

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mouismail
Copy link

@mouismail mouismail commented May 16, 2024

New Resource Implementation:

Testing:

Documentation:

  • website/docs/r/serviceendpoint_permissions.html.markdown: Updated the documentation to reflect the changes made in the pull request. The documentation now refers to the new ResourceServiceEndpointProjectPermissions resource and explains its usage and configuration. The example usage section has been updated to demonstrate the new resource. [1] [2] [3]

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #1031

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@mateustanaka
Copy link

@mouismail You implemented a new resource, why have you updated the existing documentation for azuredevops_serviceendpoint_permissions?

I guess you should create a new documentation page for azuredevops_serviceendpoint_project_permissions because each of the resources has its own responsibilities.

@xuzhang3
Copy link
Collaborator

you need to add the new resource to provider.go otherwise the provider cannot resolve this resource in ADO provider

@xuzhang3
Copy link
Collaborator

Some criteria for new resources:

  1. Add new resource ( azuredevops_xxx.go) and test code azuredevops_wiki_test.go
  2. Add the new resource to provider.go and provider_test.go
  3. Add new document for the new resource and add the index to azuredevops.erb
  4. (Optional) update the vendor if necessary
    Examples: New resource - azuredevops_check_required_template #806

@mouismail mouismail marked this pull request as draft May 21, 2024 09:14
@mouismail
Copy link
Author

Some criteria for new resources:

  1. Add new resource ( azuredevops_xxx.go) and test code azuredevops_wiki_test.go
  2. Add the new resource to provider.go and provider_test.go
  3. Add new document for the new resource and add the index to azuredevops.erb
  4. (Optional) update the vendor if necessary
    Examples: New resource - azuredevops_check_required_template #806

Working on the change together with @mateustanaka request to create a new documentation page for azuredevops_serviceendpoint_project_permissions

@mateustanaka
Copy link

Hi @mouismail any update about this item?

@mouismail
Copy link
Author

Hi @mateustanaka on it already.

@xuzhang3 xuzhang3 added the draft This issue or pull requests is in progress label Jul 4, 2024
@Sharmanand
Copy link

is there timeline this resource will be avaialble to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft This issue or pull requests is in progress new-resource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants