Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netstat): enable curated stats for tcp connections #1004

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Nov 13, 2024

Reduce cardinality of tcp_connection_stats by only keeping curated stats. Updates curated stats to include:

  • timeouts
  • loss probes
  • loss retransmit

Curation was off, but there were already several curated stats for drops and errors.

Testing

I only see these stats after this change:

networkobservability_tcp_connection_stats{statistic_name="TCPLossProbes"} 233948
networkobservability_tcp_connection_stats{statistic_name="TCPLostRetransmit"} 143
networkobservability_tcp_connection_stats{statistic_name="TCPTimeouts"} 240

In a steady state cluster, the first stat seems to slowly increase over time, and the other two are constant.

@huntergregory huntergregory requested a review from a team as a code owner November 13, 2024 19:00
@huntergregory huntergregory changed the title fix(netstat): curate stats for tcp connections fix(netstat): enable curated stats for tcp connections Nov 13, 2024
@huntergregory huntergregory added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit cf0e69a Nov 13, 2024
30 checks passed
@huntergregory huntergregory deleted the huntergregory/filter-tcp-conn-stats branch November 13, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants