Release v1.12.55 #6476
Merged
Release v1.12.55 #6476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release will include a hotfix for kiosk for two things. 1. User-added games can now have high scores. 2. The kiosk's game url will now also use the config run url and will be a relative path, making it so wherever the kiosk is running, that target is what will be used (ex: /stable---run rather than always using /---run on live).
abchatra
approved these changes
Jul 30, 2024
|
Looks good. Thanks for the due diligence. Release it when you are ready and test immediately on the live after release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release will include a hotfix for kiosk for two things.
I have tested this on stable by adding a game with high scores as top and low scores as top and both games' scores get sorted and seen as expected. I also added a game with a game over condition and no scores being stored and that exited as expected.
If you would like to further test it, make sure to make a game in stable to get the changes for the game over block: https://arcade.makecode.com/stable. As the title suggests, the arcade version should be 1.12.55 and the pxt version should be 8.5.66.