Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.12.54 #6472

Closed
wants to merge 1 commit into from
Closed

Release v1.12.54 #6472

wants to merge 1 commit into from

Conversation

srietkerk
Copy link
Contributor

Releases a hotfix to allow user-added games on kiosk to have high scores.

Releases a hotfix to allow user-added games on kiosk to have high scores.
@srietkerk srietkerk requested a review from abchatra July 22, 2024 23:33
@abchatra
Copy link
Collaborator

@srietkerk have you tested https://arcade.makecode.com/stable---kiosk to ensure everything works?

@srietkerk
Copy link
Contributor Author

No, I will do that now.

@srietkerk
Copy link
Contributor Author

Oh, I think I know why stable had stable in the play url... We should probably go back and change that.

So I can play with kiosk on stable right now, and high scores are working for old games which is good because that means the changes for the event listener in kiosk held up. However, since the run url in stable is now referencing live, I won't be receiving the game over block changes that I made when making games. I know that the changes took however, because I see the code in the files in arcade, but the events won't be received by kiosk.

@srietkerk
Copy link
Contributor Author

Going to close this since we'll want to release with the new changes/fix for using the correct run url: microsoft/pxt#10048

@srietkerk srietkerk closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants